New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PT Run] Open folder using shell instead of explorer.exe #7292
Conversation
This looks good to me but want to do a quick run here. |
@crutkas |
good callout @htcfreek. We need to refactor the code base. I think what i would do here is lets get this in and i can do the refactor. |
If possible here we should have a plugin framework with generalized functions/commands. But this is something for the future, I think. |
@htcfreek yeah, that is part of the larger plugin effort but I am going to refactor into a common place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a nice fix! In order to fully fix the issue #4622 we should also update both: To do something similar but to the directory path: eg.
|
I'm going to merge this in and then do work sometime on monday maybe on #7339 unless someone beats me to it. |
Summary of the Pull Request
Open a folder from PT Run should not use explorer.exe but the shell instead.
PR Checklist
Info on Pull Request
PT Run is now opening folder using UseShellExecute instead of explorer.exe.
Validation Steps Performed