Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geearl/7021 tag filter #509

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Geearl/7021 tag filter #509

merged 3 commits into from
Feb 27, 2024

Conversation

georearl
Copy link
Contributor

This PR adds the following features on the upload status page:

  • presents a dropdown of unique tag names and allows a selection. Filtering on the selection will be part of a future PR once we have agreed how to query across 2 cosmos containers most efficiently
  • It adds the option to select/deselect individual rows in the documents table and individual items

Copy link
Contributor

@mausolfj mausolfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tag filters. It wasn't clear to me how you determined the minWidth of columns 2-6 in /app/frontend/src/componenets/FileStatus/DocumentsDetailedList. Can you elaborate or explain?

@georearl georearl closed this Feb 26, 2024
auto-merge was automatically disabled February 26, 2024 15:38

Pull request was closed

@georearl georearl reopened this Feb 26, 2024
@georearl
Copy link
Contributor Author

Thanks for adding tag filters. It wasn't clear to me how you determined the minWidth of columns 2-6 in /app/frontend/src/componenets/FileStatus/DocumentsDetailedList. Can you elaborate or explain?

widths for columns 2-6 are as they were all along apart from the folders. I kept that column at a reasonable length, but the user has the option to change manually

ryonsteele
ryonsteele previously approved these changes Feb 26, 2024
@georearl georearl dismissed ryonsteele’s stale review February 26, 2024 16:28

The merge-base changed after approval.

mausolfj
mausolfj previously approved these changes Feb 26, 2024
Copy link
Contributor

@mausolfj mausolfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating

@georearl georearl dismissed mausolfj’s stale review February 26, 2024 16:28

The merge-base changed after approval.

mausolfj
mausolfj previously approved these changes Feb 26, 2024
Copy link
Contributor

@mausolfj mausolfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tag filters

@georearl georearl dismissed mausolfj’s stale review February 26, 2024 16:36

The merge-base changed after approval.

@georearl georearl merged commit 4014758 into vNext-Dev Feb 27, 2024
4 checks passed
@georearl georearl deleted the geearl/7021-tag-filter branch February 27, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants