Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geearl/7023 delete files from UI #510

Merged
merged 9 commits into from
Feb 26, 2024

Conversation

georearl
Copy link
Contributor

This PR hooks up basic functionality to delete files from the upload container when they are selected from the uplaod status page. Note that it only delets from teh upload container, not chunks, index items or status. Working assumption is these background items will be removed by an azure function triggered by the event of deleting the root file from the upload container

app/backend/app.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mausolfj mausolfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review comment in app backend app.py and update the log exception in deleteItems. See inline comment

corrected error msg in delete_items
Copy link
Contributor

@mausolfj mausolfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate updates to logging. This will help with debugging and maintenance going forward.

@georearl georearl merged commit 60ef7e7 into vNext-Dev Feb 26, 2024
6 checks passed
@georearl georearl deleted the geearl/7023-delete-files-from-ui branch February 26, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants