Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geearl/7427 backoff error #641

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Geearl/7427 backoff error #641

merged 2 commits into from
Apr 12, 2024

Conversation

georearl
Copy link
Contributor

@georearl georearl commented Apr 10, 2024

AB#7420

This change fixes an error that occurs when a message sent to text enrichment is requeued, due to throttling for example. The code was this...

backoff = int(os.environ["ENRICHMENT_BACKOFF"])

def requeue(response, message_json):
'''This function handles requeing and erroring of cognitive servcies'''
blob_path = message_json["blob_name"]
queued_count = message_json["text_enrichment_queued_count"]
if response.status_code == 429:
# throttled, so requeue with random backoff seconds to mitigate throttling,
# unless it has hit the max tries
if queued_count < max_requeue_count:
max_seconds = backoff * (queued_count**2)
backoff = random.randint(
backoff * queued_count, max_seconds
)

The issue being that the global var backoff is being changed within a function, which gives an error. The fix was to use a different var name downstream rather than the same var. This is the same pattern in other functions

@georearl georearl changed the base branch from main to vNext-Dev April 10, 2024 23:14
@georearl georearl merged commit 5e5eb86 into vNext-Dev Apr 12, 2024
5 of 6 checks passed
@georearl georearl deleted the geearl/7427-backoff-error branch April 12, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants