SR860: Add snapshot_base to prevent update of parameter that may not be defined #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| params_to_skip_update = [] | ||
| # we omit count_capture_kilobytes from the snapshot because | ||
| # it can only be read after a completed capture and will | ||
| # timeout otherwise when the snapshot is updated, I.e at |
There was a problem hiding this comment.
i.e. -> e.g. (I would say)
WilliamHPNielsen
approved these changes
Mar 20, 2018
Codecov Report
@@ Coverage Diff @@
## master #1013 +/- ##
=========================================
Coverage ? 78.96%
=========================================
Files ? 45
Lines ? 6445
Branches ? 0
=========================================
Hits ? 5089
Misses ? 1356
Partials ? 0 |
giulioungaretti
pushed a commit
that referenced
this pull request
Mar 20, 2018
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
SR860: Add snapshot_base to prevent update of parameter that may not be defined (#1013)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter only works after a complete capture so any automatic update will most likely fail. This cuts 5 sec off the time needed to add this to the station