Add option to remove channels from ChannelList #1045
Conversation
|
Hang on I just noticed the test that is not passing here... |
|
@Dominik-Vogel I would suggest merging #1136 first which cleans up the typing of the channellist you may also need to cast the _channels to an array after the instance check. |
|
Thank you @jenshnielsen, this is a great suggestion! |
|
By casting to an array l mean something like Which does not mention array at all, sorry for the confusion |
| @@ -263,6 +263,18 @@ def append(self, obj: InstrumentChannel): | |||
| self._channel_mapping[obj.short_name] = obj | |||
| return self._channels.append(obj) | |||
|
|
|||
| def remove(self, obj: InstrumentChannel): | |||
There was a problem hiding this comment.
It should probably have a test but was not ready to merge anyway. Somehow got pushed to master anyway by accident with failing test
There was a problem hiding this comment.
I added extensive testing and this should be good to go now, @jenshnielsen, @astafan8
…minik-Vogel/Qcodes into feat/remove_channels_from_channellist
Codecov Report
@@ Coverage Diff @@
## master #1045 +/- ##
=========================================
+ Coverage 79.64% 79.75% +0.1%
=========================================
Files 46 46
Lines 6632 6638 +6
=========================================
+ Hits 5282 5294 +12
+ Misses 1350 1344 -6 |
Tested and seems to not cause problems - travis test fails... It seems to be a mypy issue. Cannot know if it is a tuple or not.