refactor awg file handling in awg5014 driver and introduce QCoDeS @deprecated decorator #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1066 +/- ##
=======================================
Coverage 79.75% 79.75%
=======================================
Files 46 46
Lines 6647 6647
=======================================
Hits 5301 5301
Misses 1346 1346 |
|
@nataliejpg, you are absolutely right. I put one of my best men on this :) |
|
I added a deprecation warning for the |
Dominik-Vogel
changed the title
|
sounds great. Thanks @Dominik-Vogel. |
| @@ -903,7 +906,7 @@ def generate_channel_cfg(self): | |||
| been changed from their default value and put them in a | |||
| dictionary that can easily be written into an awg file, so as | |||
| to prevent said awg file from falling back to default values. | |||
| (See self.generate_awg_file and self.AWG_FILE_FORMAT_CHANNEL) | |||
| (See self.make_awg_file and self.AWG_FILE_FORMAT_CHANNEL) | |||
There was a problem hiding this comment.
You could use actual sphinx links here. https://kev.inburke.com/kevin/sphinx-interlinks/
…jpg/Qcodes into refactor/awg5014c_driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing driver had 'make_and_save' and 'make_send_and_load' which means that the code for packing a waveform list is copied in two places and also that the sequence 'make', 'save', 'send' and 'load' is not possible without making twice. I pulled out these functions and left the original two to call them so it shouldn't break it for anyone using the old ones. Thoughts welcome :)
@WilliamHPNielsen