-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set_parameter_bounds to IVVI.py #1128
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1128 +/- ##
=======================================
Coverage 79.97% 79.97%
=======================================
Files 49 49
Lines 6678 6678
=======================================
Hits 5341 5341
Misses 1337 1337 |
# self.set_parameter_bounds('dac%d' % (i+1), val, val + | ||
# self.Fullrange.0) | ||
self.set_parameter_bounds('dac%d' % (i+1), val, val + | ||
self.Fullrange.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this line split is valid python code
@@ -459,6 +460,13 @@ def get_pol_dac(self, channel): | |||
return 'POS' | |||
else: | |||
return 'Invalid polarity in memory' | |||
|
|||
def set_parameter_bounds(name, min_value, max_value): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing a self argument. Look at the function just below for an example
@kNalj Can you remove the whitespaces that Codacy noticed then I think this should be ready |
BUMP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes proposed in this pull request:
@WilliamHPNielsen