Reorder initialization of IVVI #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since set_pol_dacrack makes a call to set_parameter_bounds, and set_parameter_bounds references dacs, dacs (parameters) need to be added to the instrument before calling set_pol_dacrack
Codecov Report
@@ Coverage Diff @@
## master #1212 +/- ##
==========================================
- Coverage 80.16% 80.15% -0.02%
==========================================
Files 49 49
Lines 6762 6762
==========================================
- Hits 5421 5420 -1
- Misses 1341 1342 +1 |
astafan8
approved these changes
Jul 30, 2018
|
@kNalj please fix the Codacy complaint |
giulioungaretti
pushed a commit
that referenced
this pull request
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since set_pol_dacrack makes a call to set_parameter_bounds, and set_parameter_bounds references dacs, dacs (parameters) need to be added to the instrument before calling set_pol_dacrack
Fixes #issuenumber.
Changes proposed in this pull request:
@astafan8