Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add driver for keithley6500 #1233

Merged
merged 10 commits into from
Nov 20, 2018

Conversation

peendebak
Copy link
Contributor

@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #1233 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1233   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files          79       79           
  Lines        9188     9188           
=======================================
  Hits         6728     6728           
  Misses       2460     2460

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! but needs some minor cleanup, see comments.

qcodes/instrument_drivers/tektronix/Keithley_6500.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/tektronix/Keithley_6500.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/tektronix/Keithley_6500.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/tektronix/Keithley_6500.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/tektronix/Keithley_6500.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/tektronix/Keithley_6500.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/tektronix/Keithley_6500.py Outdated Show resolved Hide resolved
@peendebak
Copy link
Contributor Author

@Christian-Volk I addressed some of the comments, can you look at the remaining comments?

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks better! Thanks!

qcodes/instrument_drivers/tektronix/Keithley_6500.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/tektronix/Keithley_6500.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/tektronix/Keithley_6500.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/tektronix/Keithley_6500.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/tektronix/Keithley_6500.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/tektronix/Keithley_6500.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/tektronix/Keithley_6500.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/tektronix/Keithley_6500.py Outdated Show resolved Hide resolved
@astafan8 astafan8 merged commit 2c8467d into microsoft:master Nov 20, 2018
giulioungaretti pushed a commit that referenced this pull request Nov 20, 2018
Merge: 4140df2 6507966
Author: Mikhail Astafev <astafan8@gmail.com>

    Merge pull request #1233 from VandersypenQutech/feat/keithley6500
@quantumkoen quantumkoen deleted the feat/keithley6500 branch November 20, 2018 13:29
giulioungaretti pushed a commit that referenced this pull request Nov 22, 2018
Merge: 4140df2 6507966
Author: Mikhail Astafev <astafan8@gmail.com>

    Merge pull request #1233 from VandersypenQutech/feat/keithley6500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants