Feature / add label to plot_by_id #1235
Merged
+371
−204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
requested review from
jenshnielsen,
sohailc,
WilliamHPNielsen and
Dominik-Vogel
jenshnielsen
approved these changes
Aug 20, 2018
qcodes/dataset/plotting.py
Outdated
| @@ -5,6 +5,7 @@ | |||
| import matplotlib.pyplot as plt | |||
|
|
|||
| import qcodes as qc | |||
| from qcodes import load_by_id | |||
There was a problem hiding this comment.
I think it's better to use the full path for imports within qcodes. Imports from the toplevel aliases easily lead to circular imports
WilliamHPNielsen
approved these changes
Aug 20, 2018
.. instead of using the kernel from the notebook's metadata. See explanations here: jupyter/nbconvert#515 (comment) https://nbconvert.readthedocs.io/en/5.x/execute_api.html#execution-arguments-traitlets
Codecov Report
@@ Coverage Diff @@
## master #1235 +/- ##
=======================================
Coverage 80.15% 80.15%
=======================================
Files 51 51
Lines 7053 7053
=======================================
Hits 5653 5653
Misses 1400 1400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the tiny requests from #1200 was to have a default title on plots created by
plot_by_id. The title contains run id, experiment name, and sample name.Contents:
plot_by_idplot_by_id