Feature / rescale ticks and units in plot_by_id #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qcodes/dataset/plotting.py
Outdated
| unit = data_dict['unit'] | ||
|
|
||
| if unit in _SI_UNITS: | ||
| maxval = np.nanmax(data_dict['data']) |
There was a problem hiding this comment.
Should this be the max of the absolute value?
There was a problem hiding this comment.
i think it should. but the original implementation did not have it :) I'll change it and add a test for it.
astafan8
requested review from
jenshnielsen,
WilliamHPNielsen,
Dominik-Vogel and
sohailc
astafan8
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1239 +/- ##
==========================================
- Coverage 80.15% 79.18% -0.97%
==========================================
Files 51 52 +1
Lines 7053 7201 +148
==========================================
+ Hits 5653 5702 +49
- Misses 1400 1499 +99 |
This allows other functions to generate a label for a data dict without knowing about the logic that if 'label' field is empty, the 'name' field is used instead.
|
@QCoDeS/core and @ThorvaldLarsen: should the rescaling of units and ticks be enabled by default or not? |
|
@QCoDeS/core and @ThorvaldLarsen Another question: should seconds be rescaled? :) |
|
Definitely. We rarely have ks but use ns or us (microsecond) all the time. Thanks! |
astafan8
changed the title
|
@QCoDeS/core ready for review. |
WilliamHPNielsen
suggested changes
Aug 22, 2018
|
@WilliamHPNielsen added type annotations. ready for merge now? |
WilliamHPNielsen
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request along with #1200. This brings the "rescale_axis" feature of plotting functionality of the old dataset to the
plot_by_idof the new dataset. The feature scale the ticks and the units (on the axes labels) to engineering units (k,M,m,n, etc.) so that the plots are more readable. For example,2.000.000.000inVbecomes2inGVif all the numbers on this axis are not larger than 1.000.000.000.000 volts. The feature can be turned of by using a corresponding kwarg.ToDo: