plot_by_id: pass kwargs to subplots and plot function #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
reviewed
Sep 6, 2018
qcodes/dataset/plotting.py
Outdated
| axes.append(ax) | ||
| else: | ||
| if len(subplots_kwargs) == 0: |
There was a problem hiding this comment.
Should this not be !=
|
@jenshnielsen do you approve with the fixed comparison? |
Codecov Report
@@ Coverage Diff @@
## master #1258 +/- ##
==========================================
+ Coverage 70.66% 70.67% +<.01%
==========================================
Files 74 74
Lines 8165 8174 +9
==========================================
+ Hits 5770 5777 +7
- Misses 2395 2397 +2 |
jenshnielsen
reviewed
Sep 6, 2018
qcodes/dataset/plotting.py
Outdated
| FIGURE_KWARGS.remove('kwargs') | ||
| SUBPLOTS_KWARGS = set(inspect.signature(plt.subplots).parameters.keys()) | ||
| SUBPLOTS_KWARGS.remove('fig_kw') | ||
| SUBPLOTS_KWARGS = FIGURE_KWARGS.union(SUBPLOTS_KWARGS) |
There was a problem hiding this comment.
For readability i would prefer if the union was called something else that the individual set
jenshnielsen
approved these changes
Sep 6, 2018
|
I decided against a test because there are not any tests for the plotting yet (except for the labels) and it is not highest prio.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr enables the use of kwargs in
plot_by_id. The kwargs applicable toplt.subplotsare passed upon axis creation. The kwargs that remain are passed to the consequently called plotting function likeplot,scatterorpcolormesh.