Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base GroupParameter on Parameter instead of _BaseParameter #1266

Merged
merged 2 commits into from
Sep 12, 2018
Merged

Base GroupParameter on Parameter instead of _BaseParameter #1266

merged 2 commits into from
Sep 12, 2018

Conversation

sohailc
Copy link
Member

@sohailc sohailc commented Sep 12, 2018

Fixes #1265.

@astafan8

@sohailc sohailc changed the title should have fixed the minor issue Base GroupParameter on Parameter instead of _BaseParameter Sep 12, 2018
@codecov
Copy link

codecov bot commented Sep 12, 2018 •
edited

Codecov Report

Merging #1266 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1266      +/-   ##
==========================================
+ Coverage    70.7%   70.71%   +<.01%     
==========================================
  Files          74       74              
  Lines        8176     8178       +2     
==========================================
+ Hits         5781     5783       +2     
  Misses       2395     2395

astafan8
astafan8 approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nevertheless, i think we should mention that unit/label/description/other kwargs work, but other kwargs like set_cmd/get_cmd/other should not be used (preferably should be forbidden and not work). Could you add it to the docstring at least?

@sohailc
set_cmd and get_cmd should not be excepted as kwarg in GroupParameter
c662e00 
1) Check fot this and raise a value error if the kwarg is there
2) Make a test to verify this
@sohailc sohailc merged commit 78d4262 into microsoft:master Sep 12, 2018
giulioungaretti pushed a commit that referenced this pull request Sep 12, 2018
Generated gh-pages for commit 78d4262
90828d1 
Merge: c4cc88b c662e00
Author: sohail chatoor <schatoor@gmail.com>

    Merge pull request #1266 from sohailc/bug/add_kwargs_to_group_param
@sohailc sohailc deleted the bug/add_kwargs_to_group_param branch October 3, 2018 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sohailc @astafan8