Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider wait for trigger equivalent to running in wait for trigger #1283

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Consider wait for trigger equivalent to running in wait for trigger #1283

merged 1 commit into from
Sep 26, 2018

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Sep 26, 2018 •
edited

fixes #1281 @wpfff I think this solves your problem

@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #1283 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1283   +/-   ##
=======================================
  Coverage   70.92%   70.92%           
=======================================
  Files          74       74           
  Lines        8351     8351           
=======================================
  Hits         5923     5923           
  Misses       2428     2428

astafan8
astafan8 approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@astafan8 astafan8 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Jens!

@jenshnielsen jenshnielsen merged commit 6441053 into microsoft:master Sep 26, 2018
@jenshnielsen jenshnielsen deleted the awg_5208_fix_run branch September 26, 2018 08:11
giulioungaretti pushed a commit that referenced this pull request Sep 26, 2018
Generated gh-pages for commit 6441053
9f88bd9 
Merge: b6aa5b0 af5452e
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>

    Merge pull request #1283 from jenshnielsen/awg_5208_fix_run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWG 5208 behavior in play()
2 participants
@jenshnielsen @astafan8