updated/fixed ATS9870 driver #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This replaces #1183 |
jenshnielsen
approved these changes
Oct 3, 2018
astafan8
approved these changes
Oct 3, 2018
There was a problem hiding this comment.
@wpfff Thanks a lot, especially for testing! We'll do the same for the other model, and the remove AlazarParameter completely (see other @jenshnielsen PRs)
Codecov Report
@@ Coverage Diff @@
## master #1290 +/- ##
==========================================
- Coverage 70.92% 70.91% -0.02%
==========================================
Files 74 74
Lines 8352 8352
==========================================
- Hits 5924 5923 -1
- Misses 2428 2429 +1 |
|
@wpfff The last commit does not look like it belongs on this branch |
added 3 commits
October 3, 2018 11:10
|
@jenshnielsen we reverted those commits. their content is indeed in a separate PR. |
|
Great, only remaining issue is a trailing whitespace on line 28 but I am willing to let that slip and fix it in #1184 |
giulioungaretti
pushed a commit
that referenced
this pull request
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the ATS9870 to new conventions; was broken with recent changes to the ATS base driver.
this uses TraceParameter now. tested on LK1 in Delft.
@jenshnielsen @astafan8