Added driver for Basel current preamplifier. #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1327 +/- ##
=========================================
- Coverage 73.34% 73.24% -0.1%
=========================================
Files 91 92 +1
Lines 10226 10239 +13
=========================================
Hits 7500 7500
- Misses 2726 2739 +13 |
|
This looks fine as a simpel virtual driver but I wonder if this works with the remote interface https://www.physik.unibas.ch/department/infrastructure-services/electronics-lab/lnhs-i-to-v-converter-remote-control-interface-sp-983a.html that can be controlled from a computer? Is it worth adding support for that too |
|
|
||
| class SP983C(Instrument): | ||
| """ | ||
| A virtual driver for the Basel SP 983 current preamplifier. |
There was a problem hiding this comment.
This should probably also say 983c ?
astafan8
approved these changes
Nov 7, 2018
|
@emartinez I tried updating the docstrings to explain the diffs between the 2 versions of the device and that we do not use the remote control here. Could you have a look and see if that makes sense to you? Thanks |
giulioungaretti
pushed a commit
that referenced
this pull request
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a virtual driver for the Basel preamplifier.
@jenshnielsen