Meaningful exception when loading/creating dataset for non-existing run id #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1328 +/- ##
==========================================
+ Coverage 72.51% 72.53% +0.01%
==========================================
Files 74 74
Lines 8564 8570 +6
==========================================
+ Hits 6210 6216 +6
Misses 2354 2354 |
jenshnielsen
approved these changes
Oct 22, 2018
…tter_exception' into feature/load_by_id_bad_run_id_better_exception
WilliamHPNielsen
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when one uses
load_by_idfor non-existingrun_id, the exception looks like"Expected one row". This PR fixes it with:run_existsmethod tosqlite_baserun_existsinDataSetconstructor and raise exception with clear message if therun_iddoes not existNote that the used query seems to be quite fast according to this stackoverflow discussion.