Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use deprecated add_parameters in tests #1343

Merged

Conversation

jenshnielsen
Copy link
Collaborator

#1334 deprecated DataSet.add_parameters but some tests were still using it. IMHO we should either

  • Not use deprecated methods in tests
  • If we have tests that explicitly test the deprecated methods they should stay until the method is removed but the warnings should be filtered

In this case the tests does not seem to be testing add_paramters specifically so I just changed them to use add_parameter

Copy link
Contributor

@WilliamHPNielsen WilliamHPNielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. @astafan8, do you have anything against doing it this way?

@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

Merging #1343 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1343      +/-   ##
==========================================
- Coverage   72.86%   72.84%   -0.03%     
==========================================
  Files          74       74              
  Lines        8588     8588              
==========================================
- Hits         6258     6256       -2     
- Misses       2330     2332       +2

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is lovely! no objections :)

@jenshnielsen jenshnielsen merged commit b11e487 into microsoft:master Oct 26, 2018
@jenshnielsen jenshnielsen deleted the fix_deprecation_warnings branch October 26, 2018 10:24
giulioungaretti pushed a commit that referenced this pull request Oct 26, 2018
Merge: 8cc87dc fc99b85
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>

    Merge pull request #1343 from jenshnielsen/fix_deprecation_warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants