-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshot diff and method chaining #1363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Could you add some tests for both the changes?
Looks like I've got a few Mypy issues to fix as well. Let me update the PR with those once I figure it out. |
I have no idea how #1375 got mixed in with this one, sorry. Let me try to fix that. |
c8ba696
to
244c60d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1363 +/- ##
==========================================
+ Coverage 73.15% 73.22% +0.07%
==========================================
Files 79 79
Lines 9156 9188 +32
==========================================
+ Hits 6698 6728 +30
- Misses 2458 2460 +2 |
@astafan8, would you be willing to take another look? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my minor comments. Once you respond to them, this is ready to be merged.
Thanks!!!
Thanks for the review, @astafan8! |
Thanks for the example notebook! once CI passes, i will merge. |
Changes proposed in this pull request:
Measurement
methods follow fluent style to allow for method chaining.As per discussions with @astafan8 and @WilliamHPNielsen.