Fix unclarity about post_delay/inter_delay of Parameter, remove deprecated get/set delay and get/set step

[astafan8]

Parameter's post_delay and inter_delay properties have confusing descriptions. This PR addresses this.

Also remove deprecated get_delay, set_delay, get_step, set_step. Make delay kwarg a noop.

Discovered by @damazter

[codecov]

Codecov Report

Merging #1387 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1387      +/-   ##
==========================================
+ Coverage   73.38%   73.46%   +0.07%     
==========================================
  Files          79       79              
  Lines        9282     9266      -16     
==========================================
- Hits         6812     6807       -5     
+ Misses       2470     2459      -11

[jenshnielsen]

Looks good. We could also remove the deprecated delay and it's getters and setters to clear up. They have been deprecated for long enough I think

[astafan8]

@jenshnielsen Do you mean set_delay/get_delay? Shall i do it in this PR?

Shall I also remove set_step/get_step ?

[jenshnielsen]

Yes set/get delay and make the delay kwarg a noop. Fine to remove the get/set step too I think

[astafan8]

@jenshnielsen Could you confirm that i did the removal of deprecated things right? and the noop of delay?

[jenshnielsen]

@astafan8 I think this looks great. If we are extra paranoid we could make the code raise if you pass delay as a kwarg but I will not insist that is needed