Feature/dem 613/update s5i driver

[qSaevar]

Changes proposed in this pull request:

• Update qutech S5i driver

@astafan8

[codecov]

Codecov Report

Merging #1392 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1392   +/-   ##
=======================================
  Coverage   73.52%   73.52%           
=======================================
  Files          79       79           
  Lines        9267     9267           
=======================================
  Hits         6814     6814           
  Misses       2453     2453

[astafan8]

@qSaevar Could you briefly describe in the description what you did and why? (so that I don't ask gazillion of questions inside the code) for example, "removed parameter X because Y", etc. (and next time, don't commit all changes at once - instead, make one atomic change like "removed parameter X because Y", commit it, and only then commit a different change i.e. "added parameter Z because G")

[qSaevar]

@astafan8 The underlying driver, S5i_module, has been updated and this PR is first and foremost addressing those changes. The use_external_reference method has been removed from the underlying driver, so I removed that parameter. Also the set_frequency_optimally was removed from S5i_module and replaced with get_optimal_stepsize so I updated _optimize accordingly.

But since I was changing the driver, I also added the enabled parameter that can be used to switch the module's output on and off. I added docstrings to the parameters and sharpened the vals to only allow what is possible in the underlying driver for power and frequency.

The updated driver has been tested on hardware.

[astafan8]

Thanks for the description! It's now very clear!

Please go through the code and fix the concerns (especially the major ones about flexibility).

[qSaevar]

I addressed the comments, all but one, as setting limits on the stepsize is dependent on the set frequency.

[qSaevar]

And for good measure we would like to test this driver again on hardware before it is merged.

[astafan8]

This looks much better! Nevertheless, please, see the comment about enable_output kwarg and parameter.

[astafan8]

Great! Once the testing on the actual instrument is passing, let know, i'll merge.

[quantumkoen]

@astafan8 i have tested the latest changes on this branch against our setup, and can confirm that all is working as expected.