Feature / let database show version without upgrading #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamHPNielsen
force-pushed
the
database/show_upgrade_versions
branch
from
910e702
to
8042f9d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1395 +/- ##
==========================================
- Coverage 72.23% 72.22% -0.01%
==========================================
Files 83 83
Lines 9561 9566 +5
==========================================
+ Hits 6906 6909 +3
- Misses 2655 2657 +2 |
astafan8
approved these changes
Nov 26, 2018
| upgrade_actions = [perform_db_upgrade_0_to_1, perform_db_upgrade_1_to_2, | ||
| perform_db_upgrade_2_to_3] | ||
| newest_version = len(upgrade_actions) | ||
| newest_version = len(_UPGRADE_ACTIONS) |
There was a problem hiding this comment.
Shall this be extracted as well? well, at least it is extracted in #1389 in order to be used for testing.
giulioungaretti
pushed a commit
that referenced
this pull request
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed over at #1352
Changes proposed in this pull request:
@QCoDeS/core