-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature / database extract runs #1397
Feature / database extract runs #1397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready to go! It was a great freaking piece of work. I tested successfully on actual real .db files, and now everything looks fine :) Time to celebrate!
@QCoDeS/core shall we merge once CI (minus codacy, who doesn't like fixtures) is happy? |
@WilliamHPNielsen Concerning this comment when extracting to different databases:
This can cause a lot of confusion as currently the run_id and sample name are the unique identifiers that we use for a measurement run (that is the reason to have this information printed in the title of all plots). Is the idea that we should be using the guid as the unique identifier when putting datasets into presentations? I am happy to meet and discuss/learn if these concerns have already been addressed elsewhere. |
@ThorvaldLarsen as discussed offline yesterday, the core team will get together and attack this. But just for completeness, I note here that I currently think changing the identifier you use is better. The dataset name seems like a good pick. |
Fixes #1217
Changes proposed in this pull request:
extract_runs_into_db
that takes a set of run_ids from one database file and inserts those runs into another database file.The current limitations and behaviours are:
extract_runs_into_db
upgrade the source DB.it will be upgradedand is in an old version, the user will be warned similarly to how it works for the source DB.@QCoDeS/core