Homogeneous coordinates for field vectors in Mercury iPS #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds functionality to FieldVector that allows for it to be used as a snapshotable parameter, and that adds conversion to and from homogeneous coordinate representations to make it easier to transform FieldVector instances. This functionality is used by the new field-valued parameters of the MercuryiPS instrument. This commit has been made via `git checkout <files> -p` in order to take only changes of interest from a branch that contained more changes. In order to preserve the reference to the original author of this work, the "cherry picked from..." lines are added below. (cherry picked from commit f1bf38b) (cherry picked from commit 3c8a0a1) (cherry picked from commit 251a2f4) (cherry picked from commit b31fa46) (cherry picked from commit 5e23cd6)
astafan8
requested review from
cgranade,
jenshnielsen,
WilliamHPNielsen and
Dominik-Vogel
Codecov Report
@@ Coverage Diff @@
## master #1398 +/- ##
==========================================
- Coverage 74.13% 74.09% -0.05%
==========================================
Files 85 85
Lines 9822 9883 +61
==========================================
+ Hits 7282 7323 +41
- Misses 2540 2560 +20 |
jenshnielsen
approved these changes
Nov 28, 2018
There was a problem hiding this comment.
Looks fine to me. We could add some more validators to the new parameters? @WilliamHPNielsen should probably sign off on this as the original writer of the driver
WilliamHPNielsen
suggested changes
Dec 4, 2018
WilliamHPNielsen
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to
FieldVectorthat allows for it to be used as a snapshotable parameter, and that adds conversion to and from homogeneous coordinate representations to make it easier to transformFieldVectorinstances. This functionality is used by the new field-valued parameters of theMercuryiPSinstrument.Developed by @cgranade in collaboration with @wpfff.
This functionality is "sort-of-cheery-picked" from #1348. #1348 also contains
asyncramping, but that requires more work, hence this PR. The proposal is to merge this independently fromasyncpart.@cgranade Could you have a look at this and tell me if I missed any functionality that enables automated field ramping that you've implemented for pytopo? (without async parts)