Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/keysight 33xx pulsewidth #1405

Merged

Conversation

neildick
Copy link
Contributor

@neildick neildick commented Dec 3, 2018

Hi guys,

Just a few quick changes

Changes proposed in this pull request:

  • Add pulse width parameter
  • Add the 33511B model

@WilliamHPNielsen @jenshnielsen

Neil Dick added 2 commits December 3, 2018 14:05
The 33511B is a single channel model with a maximum frequency
of 20 MHz.
Add a channel parameter to set the width of the pulse function
@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #1405 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1405      +/-   ##
==========================================
+ Coverage   73.24%   73.24%   +<.01%     
==========================================
  Files          85       85              
  Lines        9832     9833       +1     
==========================================
+ Hits         7201     7202       +1     
  Misses       2631     2631

Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neildick Thanks, looks good to me

@jenshnielsen jenshnielsen merged commit 4f8ec1d into microsoft:master Dec 3, 2018
giulioungaretti pushed a commit that referenced this pull request Dec 3, 2018
Merge: f8afd73 d99f93d
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>

    Merge pull request #1405 from neildick/feature/keysight_33xx_pulsewidth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants