-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend RTO1000 driver #1410
Extend RTO1000 driver #1410
Conversation
…t and next; corrected the stop_opc and opc paramaters; Added trigger mode paramater and added docstring to High defintion mode
Codecov Report
@@ Coverage Diff @@
## master #1410 +/- ##
==========================================
+ Coverage 73.3% 73.33% +0.03%
==========================================
Files 91 91
Lines 10189 10225 +36
==========================================
+ Hits 7469 7499 +30
- Misses 2720 2726 +6 |
…mode val_mapping to vals
I've made the requested changes, @sohailc can you continue your review? |
@WilliamHPNielsen can you review this pr, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good and comprehensive, thank you for adding all this to the driver. I don't have the scope myself, but I trust that these settings are indeed agreeing with the instrument firmware.
I have only a very shallow request and and optional one. Shallow: could you please go through the code and fix typos in the docstrings? The word "measurement" is misspelled in many places (plus a few other typos). Optional: could you be talked into updating the example notebook for this driver with these changes? It's a bit of work, since you'd need to hook up a signal generator to the scope to recreate the existing notebook, but it would be fantastic to have these new features documented somewhere.
…ions, trigger value_mapping to validator, Fixed typos; Added measurement to the RTO1000 example program
@nyxus, great! I noticed that you also added some more functionality. Is the driver done now, or are you going to add more later? |
I've made the changes as requested, including expending the example notebook. Also added a couple of other functions to the driver to readout if the scope is running, triggered and acquiring data. These functions are used to check if a measurement is possible. The example notebook also contains a useful function to kind off automate the process of measuring. |
@WilliamHPNielsen The driver is done for now. It still misses lots of functions/parameters but I did not need them. I will create new PR(s) if that changes. |
@WilliamHPNielsen is this ready to merge? |
@jenshnielsen, yes, I believe it is (sorry for slow response). |
Hi,
I've fixed problems, extended and improved the RTO1000 driver. The main extension is the measurement submodule. This allows the sure to setup, start and clear all 8 measurements. I've tested this PR using an RTO1024 on my desk.
Changes proposed in this pull request:
Driver
Driver example
@WilliamHPNielsen @AdriaanRol