Extension/lakeshore read curve file #1421
Conversation
2) bug fix in "upload_curve": should be index - 1 when selecting the right curve
|
|
||
| def split_data_line( | ||
| line: str, | ||
| parsers: Union[type, List]=str |
There was a problem hiding this comment.
the List case seems to never been used, hence please remove the support for it.
|
|
||
| Header1 Header2 Header3 | ||
| data11 data12 data13 | ||
| data21 data22 data23 |
There was a problem hiding this comment.
please also document the format of the returned dictionary.
| the dictionary as expected by the 'upload_curve' method of the | ||
| driver | ||
|
|
||
| Note: This function modifies the input |
There was a problem hiding this comment.
why was this decision made instead of letting this function return a new dictionary object?
There was a problem hiding this comment.
Yeah its cleaner to make and modify a copy
| # Look up under the 'Data Format' entry to find what units we have | ||
| data_format = file_data['Data Format'] | ||
| # This is a string in the form '4 (Log Ohms/Kelvin)' | ||
| data_format_int = int(data_format[0]) |
There was a problem hiding this comment.
what is the total number of supported units? is it indeed 4 as valid_sensor_units suggests? regardless, i'd make this line a bit more robust via ... = int(data_format.split()[0]), is it fair to do so?
| """ | ||
| _, filename = os.path.split(file_path) | ||
| if not filename.endswith(".330"): | ||
| raise ValueError("Only curve files with extension *.330 is supported") |
There was a problem hiding this comment.
| raise ValueError("Only curve files with extension *.330 is supported") | |
| raise ValueError("Only curve files with extension *.330 are supported") |
| Upload a curve from a curve file. Note that we only support | ||
| curve files with extension *.330 | ||
| """ | ||
| _, filename = os.path.split(file_path) |
There was a problem hiding this comment.
why is this needed? isn't filename.endswith(".330") == file_path.endswith(".330")?
Codecov Report
@@ Coverage Diff @@
## master #1421 +/- ##
=======================================
Coverage 74.47% 74.47%
=======================================
Files 85 85
Lines 9960 9960
=======================================
Hits 7418 7418
Misses 2542 2542 |
|
@astafan8 Can you have another look |
| parser(i) for parser, i in zip(parsers, line_split) | ||
| ] | ||
| def split_data_line(line: str, parser: type = str) -> List[str]: | ||
| return [parser(i) for i in line.split(" ") if i != ""] | ||
|
|
||
| def strip(strings: Iterable[str]) -> Tuple: |
…ion/lakeshore_read_curve_file
…com/sohailc/Qcodes into extension/lakeshore_read_curve_file
Added the ability to parse and load curve files.