fix: Handle 'inf' in _convert_numeric #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading data from the sqlite database goes through a converter (_convert_numeric) in qcodes/dataset/sqlite_base.py that now can handle 'inf' as the numeric value properly. Previously, I threw an error because it incorrectly assumed that 'inf' would be an integer.
Codecov Report
@@ Coverage Diff @@
## master #1449 +/- ##
=========================================
+ Coverage 73.8% 73.8% +<.01%
=========================================
Files 92 92
Lines 10444 10446 +2
=========================================
+ Hits 7708 7710 +2
Misses 2736 2736 |
astafan8
requested changes
Jan 17, 2019
There was a problem hiding this comment.
This looks great!
Could you add a test for it (smth similar to this https://github.com/QCoDeS/Qcodes/blob/a3113ee98f8522490f90578236b0b92eb7763999/qcodes/tests/dataset/test_dataset_basic.py#L580-L587) ?
…m/simonzihlmann/Qcodes into fix/handle_inf_in_convert_numeric Update local version of branch
Test that we can insert and retrieve numpy inf in the data set
astafan8
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading data from the sqlite database goes through a converter (_convert_numeric) in qcodes/dataset/sqlite_base.py that now can handle 'inf' as the numeric value properly. Previously, it threw an error because it incorrectly assumed that 'inf' would be an integer.
@astafan8