Use getattr to get ask/write from instruments #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to use InstrumentBase as the base class for virtual instruments
Codecov Report
@@ Coverage Diff @@
## master #1451 +/- ##
==========================================
+ Coverage 73.24% 73.47% +0.22%
==========================================
Files 92 92
Lines 10239 10239
==========================================
+ Hits 7500 7523 +23
+ Misses 2739 2716 -23 |
|
Seems reasonable enough. Could you add a test based on the code in #1450 |
astafan8
reviewed
Jan 21, 2019
|
@jenshnielsen @astafan8 added some extra tests on all the changes. Not sure why the Azure test failed, I don't seem to have access to it... |
|
It seems to be a random networking error during the docs build. I have restarted |
astafan8
approved these changes
Jan 22, 2019
|
|
||
|
|
||
| class MockMetaParabola(Instrument): | ||
| class MockMetaParabola(InstrumentBase): |
There was a problem hiding this comment.
well done finding this test suite :)
giulioungaretti
pushed a commit
that referenced
this pull request
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use InstrumentBase as the base class for virtual instruments
Fixes #1450.
Changes proposed in this pull request:
@jenshnielsen @astafan8