Fixed issue with legacy import #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue, for a 2d sweep of e.g. gates both parameters would have name \'v\'
|
@ectof I think this looks good. I have updated the automatic tests to reflect the changes |
Codecov Report
@@ Coverage Diff @@
## master #1459 +/- ##
=======================================
Coverage 73.76% 73.76%
=======================================
Files 92 92
Lines 10351 10351
=======================================
Hits 7635 7635
Misses 2716 2716 |
astafan8
approved these changes
Feb 1, 2019
giulioungaretti
pushed a commit
that referenced
this pull request
Feb 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced array.name for array.array_id in dataset.legacy_import.
Reason: the array.name was often non-unique for distinct parameters, e.g in a 2d sweep of two gates both parameters would have array.name 'v'
tested by Eoin
@jenshnielsen