Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document exporting of data from dataset #1462

Merged

Conversation

jenshnielsen
Copy link
Collaborator

Planing to also add a more detailed notebook

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #1462 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1462   +/-   ##
=======================================
  Coverage   73.86%   73.86%           
=======================================
  Files          92       92           
  Lines       10410    10410           
=======================================
  Hits         7689     7689           
  Misses       2721     2721

@WilliamHPNielsen
Copy link
Contributor

I like it. It's a really good idea to introduce data export/retrieval upfront in the context manager notebook and to sprinkle examples of using it out through the notebook.

Comments on the notebooks:

  • The measurement context manager notebook still has an experimental feel to it. Many paragraphs are unchanged since I originally wrote them to convince the world that we could do better than the old Loop. We should rewrite the whole thing into a more authoritative tutorial tone. Perhaps in a separate PR. The changes introduced in this PR are clear improvements.
  • The Working-With... notebook is sweet! There is a fair amount of typos, though. I wouldn't mind going through it and fixing them. It's usually faster/easier for another person than the original author to do that.

@jenshnielsen
Copy link
Collaborator Author

Sure that sounds good. I agree that we should rewrite the context manager notebook and it should be more of a getting started kind of thing

Copy link
Contributor

@WilliamHPNielsen WilliamHPNielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now.

@jenshnielsen jenshnielsen changed the title [WIP] Document exporting of data from dataset Document exporting of data from dataset Feb 6, 2019
@jenshnielsen jenshnielsen merged commit d2bba3d into microsoft:master Feb 6, 2019
@jenshnielsen jenshnielsen deleted the docs/dataexport_notebook branch February 6, 2019 14:12
giulioungaretti pushed a commit that referenced this pull request Feb 6, 2019
Merge: 77617bc a436656
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>

    Merge pull request #1462 from jenshnielsen/docs/dataexport_notebook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants