Dev/b2200 switch matrix multiple channel connect #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
approved these changes
Feb 20, 2019
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| from qcodes import VisaInstrument | |||
| from qcodes.utils.validators import MultiType, Ints, Enum, Lists | |||
| from typing import List, Tuple | |||
|
|
|||
|
|
|||
| def post_execution_status_poll(func): | |||
There was a problem hiding this comment.
as the mypy output of the CI suggests, you need to add type hints to this decorator. you can read about this online, but perhaps smth simple like def post_execution_status_poll(func: Callable) -> Callable: could work.
Codecov Report
@@ Coverage Diff @@
## master #1480 +/- ##
==========================================
+ Coverage 73.88% 73.91% +0.03%
==========================================
Files 92 92
Lines 10420 10433 +13
==========================================
+ Hits 7699 7712 +13
Misses 2721 2721 |
giulioungaretti
pushed a commit
that referenced
this pull request
Feb 20, 2019
StefanD986
deleted the
dev/b2200_switch_matrix_multiple_channel_connect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature for B2200 switch matrix driver:
Changes proposed in this pull request:
connect_paths()anddisconnect_paths())connect()multiple times in a loop.Includes tests and updated example notebook.
@astafan8