Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/better parameter docs #1485

Merged
merged 16 commits into from
Feb 21, 2019
Merged

Docs/better parameter docs #1485

merged 16 commits into from
Feb 21, 2019

Conversation

jenshnielsen
Copy link
Collaborator

Pulled the improvements to the api docs out of #1478 To make that pr more focused. We can certainly improve these docs further but I think this is already a significant update

jenshnielsen and others added 10 commits February 21, 2019 14:53
@jenshnielsen
Cleanup documentation of parameter
fde036a
@jenshnielsen
Cleanup documentation of parametergroup
7ed57db
@jenshnielsen
Significant updates to parameter docs
18c582d
@astafan8 @jenshnielsen
Update qcodes/instrument/parameter.py
4c6ee90 
Co-Authored-By: jenshnielsen <jenshnielsen@gmail.com>
@astafan8 @jenshnielsen
Update qcodes/instrument/parameter.py
70f5f18 
Co-Authored-By: jenshnielsen <jenshnielsen@gmail.com>
@astafan8 @jenshnielsen
Update qcodes/instrument/parameter.py
9114117 
Co-Authored-By: jenshnielsen <jenshnielsen@gmail.com>
@jenshnielsen
typo
209c89e
@jenshnielsen
remove useless link that doesnt work
23b0bee
@jenshnielsen
better docstring for metadata
0fe5a98
@jenshnielsen
update array/multiparameter
0c37e80 
remove out of date comment and direct users of arrayparameter towards parameterwithsetpoints
WilliamHPNielsen
WilliamHPNielsen approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@WilliamHPNielsen WilliamHPNielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great improvement. I left a few minor comments.

@codecov
Copy link

codecov bot commented Feb 21, 2019 •
edited

Codecov Report

Merging #1485 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1485   +/-   ##
=======================================
  Coverage   73.76%   73.76%           
=======================================
  Files          92       92           
  Lines       10437    10437           
=======================================
  Hits         7699     7699           
  Misses       2738     2738

@jenshnielsen jenshnielsen merged commit 25ee472 into microsoft:master Feb 21, 2019
@jenshnielsen jenshnielsen deleted the docs/better_parameter_docs branch February 21, 2019 20:57
giulioungaretti pushed a commit that referenced this pull request Feb 21, 2019
Generated gh-pages for commit 25ee472
69b2fa9 
Merge: 1029a18 0a266b1
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>

    Merge pull request #1485 from jenshnielsen/docs/better_parameter_docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamHPNielsen WilliamHPNielsen WilliamHPNielsen approved these changes

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jenshnielsen @astafan8 @WilliamHPNielsen