Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename mark_complete to mark_completed #1495

Merged
merged 4 commits into from
Feb 28, 2019

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Feb 28, 2019

Extracted from the dsi branch #1415

This change is not really related to the dsi branch and applying this separately removes a lot of noise from that branch.

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #1495 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1495      +/-   ##
==========================================
+ Coverage   73.75%   73.78%   +0.02%     
==========================================
  Files          92       92              
  Lines       10437    10439       +2     
==========================================
+ Hits         7698     7702       +4     
+ Misses       2739     2737       -2

@jenshnielsen jenshnielsen merged commit 1cb3776 into microsoft:master Feb 28, 2019
@jenshnielsen jenshnielsen deleted the feature/mark_completed branch February 28, 2019 16:42
giulioungaretti pushed a commit that referenced this pull request Feb 28, 2019
Merge: 5bd7137 a9b591f
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>

    Merge pull request #1495 from jenshnielsen/feature/mark_completed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants