Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use perf_counter, not monotonic for DB flushing #1498

Merged
merged 7 commits into from
Jul 2, 2019
Merged

Use perf_counter, not monotonic for DB flushing #1498

merged 7 commits into from
Jul 2, 2019

Conversation

astafan8
Copy link
Contributor

@astafan8 astafan8 commented Mar 1, 2019

Let's see it works. perf_counter has more resolution than monotonic, which is better for smaller write_periods. Presumably.

@astafan8 astafan8 closed this Mar 5, 2019
@astafan8 astafan8 reopened this Mar 5, 2019
@WilliamHPNielsen
Copy link
Contributor

Looks good. Any reason for this PR to be marked as draft? It looks pretty done to me.

@astafan8 astafan8 marked this pull request as ready for review March 7, 2019 12:54
@codecov
Copy link

codecov bot commented Mar 7, 2019 •
edited

Codecov Report

Merging #1498 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1498   +/-   ##
=======================================
  Coverage   70.55%   70.55%           
=======================================
  Files         123      123           
  Lines       14921    14921           
=======================================
  Hits        10528    10528           
  Misses       4393     4393

WilliamHPNielsen
WilliamHPNielsen approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@WilliamHPNielsen WilliamHPNielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessir

@astafan8 astafan8 merged commit 86e61d1 into master Jul 2, 2019
@astafan8 astafan8 deleted the astafan8-flush-db-monotonic branch July 2, 2019 11:21
giulioungaretti pushed a commit that referenced this pull request Jul 2, 2019
Generated gh-pages for commit 86e61d1
ae2d1f4 
Merge: 49b7d58 108e0bd
Author: Mikhail Astafev <astafan8@gmail.com>

    Merge pull request #1498 from QCoDeS/astafan8-flush-db-monotonic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamHPNielsen WilliamHPNielsen WilliamHPNielsen approved these changes

Assignees
No one assigned
Labels
new dataset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@astafan8 @WilliamHPNielsen @jenshnielsen