Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver/gentec maestro #1507

Merged
merged 10 commits into from
Apr 9, 2019
Merged

Conversation

SvenBo90
Copy link
Contributor

@SvenBo90 SvenBo90 commented Mar 5, 2019

feat: New driver

Driver for Gentec Maestro and example notebook

no breaking changes

feat: New driver

Driver for Andor DU401 and example notebook

no breaking changes
feat: New driver

Driver for Gentec Maestro and example notebook

no breaking changes
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #1507 into master will decrease coverage by 0.14%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1507      +/-   ##
==========================================
- Coverage   70.66%   70.52%   -0.15%     
==========================================
  Files         102      103       +1     
  Lines       11585    11608      +23     
==========================================
  Hits         8186     8186              
- Misses       3399     3422      +23

qcodes/instrument_drivers/Gentec/Gentec_Maestro.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/Gentec/Gentec_Maestro.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/Gentec/Gentec_Maestro.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/Gentec/Gentec_Maestro.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/Gentec/Gentec_Maestro.py Outdated Show resolved Hide resolved
@astafan8 astafan8 added the driver label Mar 7, 2019
feat: Update driver

Fixes for the driver for Gentec Maestro and example notebook

no breaking changes
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looks decent! Thank you for incorporating the feedback. I still left some comments, but the driver is almost ready.

qcodes/instrument_drivers/Gentec/Gentec_Maestro.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/Gentec/Gentec_Maestro.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/Gentec/Gentec_Maestro.py Outdated Show resolved Hide resolved
feat: New driver

Driver for Gentec Maestro and example notebook

no breaking changes
feat: New driver

Driver for Gentec Maestro and example notebook

no breaking changes
@astafan8 astafan8 merged commit c3fdff4 into microsoft:master Apr 9, 2019
giulioungaretti pushed a commit that referenced this pull request Apr 9, 2019
Merge: 7fee23c b8b17f9
Author: Mikhail Astafev <astafan8@gmail.com>

    Merge pull request #1507 from SvenBo90/driver/Gentec_Maestro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants