-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driver/gentec maestro #1507
Merged
Merged
Driver/gentec maestro #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: New driver Driver for Andor DU401 and example notebook no breaking changes
Andor DU401 driver
Revert "Andor DU401 driver"
feat: New driver Driver for Gentec Maestro and example notebook no breaking changes
Codecov Report
@@ Coverage Diff @@
## master #1507 +/- ##
==========================================
- Coverage 70.66% 70.52% -0.15%
==========================================
Files 102 103 +1
Lines 11585 11608 +23
==========================================
Hits 8186 8186
- Misses 3399 3422 +23 |
astafan8
requested changes
Mar 5, 2019
feat: Update driver Fixes for the driver for Gentec Maestro and example notebook no breaking changes
…codes into driver/Gentec_Maestro
astafan8
approved these changes
Apr 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looks decent! Thank you for incorporating the feedback. I still left some comments, but the driver is almost ready.
feat: New driver Driver for Gentec Maestro and example notebook no breaking changes
feat: New driver Driver for Gentec Maestro and example notebook no breaking changes
giulioungaretti
pushed a commit
that referenced
this pull request
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: New driver
Driver for Gentec Maestro and example notebook
no breaking changes