-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boxcar average option to M4i driver #1509
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1509 +/- ##
=======================================
Coverage 73.81% 73.81%
=======================================
Files 92 92
Lines 10434 10434
=======================================
Hits 7702 7702
Misses 2732 2732 |
Codecov Report
@@ Coverage Diff @@
## master #1509 +/- ##
======================================
Coverage 73.8% 73.8%
======================================
Files 92 92
Lines 10444 10444
======================================
Hits 7708 7708
Misses 2736 2736 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactoring (apart from the new "features") that reduces code duplication!
@astafan8 Addressed the comments. I am not sure about my solution to fix a mypy error (line 804). Do you have a better alternative? |
I'd suggest the following: sample_ctype: Type
if bytes_per_sample == 2:
sample_ctype = ct.c_int16
elif bytes_per_sample == 4:
sample_ctype = ct.c_int32
else: or a stricter version sample_ctype: Union[Type[ct.c_int16], Type[ct.c_int32]] Could you try them and see which one works? |
e509dde
to
dd5e70a
Compare
Changes proposed in this pull request:
__transfer_buffer_numpy
method@WilliamHPNielsen @astafan8