Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logger docs #1517

Merged
merged 11 commits into from
Apr 3, 2019
Merged

Update logger docs #1517

merged 11 commits into from
Apr 3, 2019

Conversation

jenshnielsen
Copy link
Collaborator

Start working on improving the api docs for the logging modue

@jenshnielsen jenshnielsen marked this pull request as ready for review March 11, 2019 11:21
@jenshnielsen
Copy link
Collaborator Author

@Dominik-Vogel Could you have a look at this since you wrote most of the logging module

@codecov
Copy link

codecov bot commented Mar 11, 2019 •
edited

Codecov Report

Merging #1517 into master will not change coverage.
The diff coverage is 80%.

@@           Coverage Diff           @@
##           master    #1517   +/-   ##
=======================================
  Coverage   70.66%   70.66%           
=======================================
  Files         102      102           
  Lines       11585    11585           
=======================================
  Hits         8186     8186           
  Misses       3399     3399

@jenshnielsen jenshnielsen force-pushed the docs/cleanup_logger branch 2 times, most recently from 0e83f59 to d9dd8ff Compare March 13, 2019 09:59
@jenshnielsen jenshnielsen mentioned this pull request Mar 13, 2019
Merged
@astafan8 astafan8 added the docs Related to docs improvements label Apr 1, 2019
Dominik-Vogel
Dominik-Vogel approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@Dominik-Vogel Dominik-Vogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Jens, these are all great improvements, that help to make the docs of the logging module a lot more readable and also understandable!

qcodes/logger/instrument_logger.py Outdated Show resolved Hide resolved
@jenshnielsen jenshnielsen merged commit fa0b8d2 into microsoft:master Apr 3, 2019
@jenshnielsen jenshnielsen deleted the docs/cleanup_logger branch April 3, 2019 10:39
giulioungaretti pushed a commit that referenced this pull request Apr 3, 2019
Generated gh-pages for commit fa0b8d2
0264940 
Merge: 8f450ae 0fe1716
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>

    Merge pull request #1517 from jenshnielsen/docs/cleanup_logger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dominik-Vogel Dominik-Vogel Dominik-Vogel approved these changes

Assignees
No one assigned
Labels
docs Related to docs improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jenshnielsen @Dominik-Vogel @astafan8