Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alazar add get/set parameter #1523

Merged
merged 5 commits into from
Apr 1, 2019
Merged

Alazar add get/set parameter #1523

merged 5 commits into from
Apr 1, 2019

Conversation

jenshnielsen
Copy link
Collaborator

This is useful as it among other things can be used to inspect the status of the buffers added to the card.

@codecov
Copy link

codecov bot commented Mar 19, 2019 •
edited

Codecov Report

Merging #1523 into master will increase coverage by 0.08%.
The diff coverage is 94.87%.

@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
+ Coverage   70.57%   70.66%   +0.08%     
==========================================
  Files         102      102              
  Lines       11546    11585      +39     
==========================================
+ Hits         8149     8186      +37     
- Misses       3397     3399       +2

astafan8
astafan8 approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, modulo style-related comments.

qcodes/instrument_drivers/AlazarTech/constants.py Show resolved Hide resolved
qcodes/instrument_drivers/AlazarTech/constants.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/AlazarTech/constants.py Outdated Show resolved Hide resolved
qcodes/instrument_drivers/AlazarTech/ats_api.py Show resolved Hide resolved
jenshnielsen and others added 4 commits April 1, 2019 11:04
@jenshnielsen
Add functions to call Alazar(Set|Get)Parameter
9144d0d 
These are useful among other things because you can get the number of
filled buffers and the number of free ones.
@jenshnielsen
Add enums related to AlazarGet|SetParameter
3b133e1
@jenshnielsen
remove trailing whitespaces
62cc0e6
@jenshnielsen
review feedback
f225ac6
@jenshnielsen
Copy link
Collaborator Author

@astafan8 I think this addresses all your comments

@jenshnielsen
Copy link
Collaborator Author

@astafan8 How you you feel about calling it AlazarParameter Parameter breaks the docs build. We could fix that but I think it's too generic anyway

@astafan8
Copy link
Contributor

astafan8 commented Apr 1, 2019

@jenshnielsen I see, yes, AlazarParameter should be quite good actually.

@jenshnielsen jenshnielsen merged commit 7479f7a into microsoft:master Apr 1, 2019
giulioungaretti pushed a commit that referenced this pull request Apr 1, 2019
Generated gh-pages for commit 7479f7a
3edd06b 
Merge: 7d35d81 029fe03
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>

    Merge pull request #1523 from jenshnielsen/alazar_get_set_parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
driver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jenshnielsen @astafan8