Alazar Driver: Add api instance as initialization parameter #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dominik-Vogel
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1524 +/- ##
=======================================
Coverage 71.54% 71.54%
=======================================
Files 105 105
Lines 12139 12139
=======================================
Hits 8685 8685
Misses 3454 3454 |
astafan8
requested changes
Mar 20, 2019
Co-Authored-By: Dominik-Vogel <30660470+Dominik-Vogel@users.noreply.github.com>
Co-Authored-By: Mikhail Astafev <astafan8@gmail.com>
…s into driver_ats_api_input
astafan8
approved these changes
May 13, 2019
Co-Authored-By: Mikhail Astafev <astafan8@gmail.com>
…s into driver_ats_api_input
Dominik-Vogel
changed the title
giulioungaretti
pushed a commit
that referenced
this pull request
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this small change I will be able to create a mock of the alazar driver that does not require an alazar card in order to instantiate and also potentially benchmark the alazar and alazar controllers, by simply providing an instance of an api object that wraps all the dll calls without actually calling into the dll.