added a driver for the Keithley 2450 #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e". We need to then explicitly check if the current language is not "TSP". If som raise a runtime error.
Codecov Report
@@ Coverage Diff @@
## master #1533 +/- ##
=======================================
Coverage 71.33% 71.33%
=======================================
Files 104 104
Lines 12041 12041
=======================================
Hits 8589 8589
Misses 3452 3452 |
…g a warning and change the compatibility more to True. This will automatically raise a run time error as we are changing the language setting.
|
@WilliamHPNielsen @jenshnielsen @Dominik-Vogel @astafan8 Can someone look at my code, please? |
…m: Make private parameters for all functions and select the appropriate one with a property returning a parameter 2) Add an array parameter for taking sweeps
sohailc
changed the title
…PIArgs # Conflicts: # qcodes/utils/validators.py
2) mypy passes
… keithley_2450
2) Improved docstrings 3) example notebook up to date todo: mypy
2) Processed PR comments.
|
@jenshnielsen @astafan8 I have improved my driver... can we have another look at it? |
2) More comprehensive testing
…function to "voltage" before doing anything else
astafan8
approved these changes
Apr 30, 2019
There was a problem hiding this comment.
Nice, looks decent! Left some last comments.
And a couple of wishes for the future:
- if the PR becomes too big, as in there are too many changes to be made, it is more convenient to close the existing PR, and open another one that does not have the previous comments. This is very much applicable in this case, because the driver was basically rewritten.
- please try to respond to all the comments in one way or another. at least, use the "resolve conversation" button - this really helps to see which comments have already been addressed and which ones are still to be discussed or tackled.
|
I am happy to have this merged once @astafan8 s comments have been addressed. |
…not Callable. 2) Add whitespace in warning message when detecting unsupported language mode.
…mpleting a measurement.
jenshnielsen
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A driver for the Keithley 2450 has been added.