Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of oscillators should be 8 if MF enabled #1546

Merged
merged 4 commits into from
Apr 29, 2019
Merged

Number of oscillators should be 8 if MF enabled #1546

merged 4 commits into from
Apr 29, 2019

Conversation

qSaevar
Copy link
Contributor

@qSaevar qSaevar commented Apr 25, 2019

Changes proposed in this pull request:

  • If MF is enabled in ZI UHFLI there are 8 oscillators that can be controlled.
  • Sampling rate as float should return exact value, not rounded off value.

@WilliamHPNielsen

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #1546 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1546      +/-   ##
==========================================
- Coverage   71.23%   71.22%   -0.01%     
==========================================
  Files         103      103              
  Lines       11994    11994              
==========================================
- Hits         8544     8543       -1     
- Misses       3450     3451       +1

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #1546 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1546   +/-   ##
=======================================
  Coverage   71.22%   71.22%           
=======================================
  Files         103      103           
  Lines       12002    12002           
=======================================
  Hits         8549     8549           
  Misses       3453     3453

@WilliamHPNielsen
Copy link
Contributor

WilliamHPNielsen commented Apr 26, 2019

Let me see if I get this...

I'll just trust you on the number of oscillators. Regarding the frequency, the point is that the graphical interface specifies the available sampling rates as

['1.80 GHz', '900 MHz', '450 MHz', '225 MHz', '113 MHz', '56.2 MHz',
'28.1 MHz', '14.0 MHz', '7.03 MHz', '3.50 MHz', '1.75 MHz', '880 kHz', '440 kHz', '220
kHz', '110 kHz', '54.9 kHz', '27.5 kHz']

but you and I both know that these numbers are not exact, merely rounded off to 3 significant digits. In fact, the true frequencies are 1.80 GHz divided by 2**n, which means that (in Hz), they are

[1800000000.0,
 900000000.0,
 450000000.0,
 225000000.0,
 112500000.0,
 56250000.0,
 28125000.0,
 14062500.0,
 7031250.0,
 3515625.0,
 1757812.5,
 878906.25,
 439453.125,
 219726.5625,
 109863.28125,
 54931.640625,
 27465.8203125]

, i.e. all numbers that can be represented exactly.

Okay, I get it. I agree.

@WilliamHPNielsen
Copy link
Contributor

The only weakness is: how well do we know the original frequency?

@qSaevar ?

@qSaevar
Copy link
Contributor Author

qSaevar commented Apr 26, 2019

@WilliamHPNielsen the original frequency? Do you mean the base 1.8GHz or the internal ref frequency? In the manual it is stated that the short term stability of the internal clock is 0.00005 ppm with typical initial accuracy of +/- 0.5 ppm and max of +/- 1 ppm. But then there is the possibility of using an external reference clock...

@qSaevar
Copy link
Contributor Author

qSaevar commented Apr 29, 2019

@WilliamHPNielsen I fixed the setter for sampling rate and I have tested this on hardware. Should I do anything else? Or what is the status of this PR.

@WilliamHPNielsen
Copy link
Contributor

WilliamHPNielsen commented Apr 29, 2019

@qSaevar I meant the base frequency of 1.8 GHz. If that could potentially be 1.804 GHz, things would be bad. But you've answered that question now, thanks.

We'll merge once CI is happy.

@qSaevar
Copy link
Contributor Author

qSaevar commented Apr 29, 2019

@WilliamHPNielsen That's great, thanks

@WilliamHPNielsen WilliamHPNielsen merged commit abe107c into microsoft:master Apr 29, 2019
@qSaevar qSaevar deleted the MF-option-for-oscillators-in-UHFLI branch April 29, 2019 13:52
giulioungaretti pushed a commit that referenced this pull request Apr 29, 2019
Merge: 30644a6 3cf1eb6
Author: William H.P. Nielsen <whpn@mailbox.org>

    Merge pull request #1546 from qutech-sd/MF-option-for-oscillators-in-UHFLI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants