-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Number of oscillators should be 8 if MF enabled #1546
Number of oscillators should be 8 if MF enabled #1546
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1546 +/- ##
==========================================
- Coverage 71.23% 71.22% -0.01%
==========================================
Files 103 103
Lines 11994 11994
==========================================
- Hits 8544 8543 -1
- Misses 3450 3451 +1 |
Codecov Report
@@ Coverage Diff @@
## master #1546 +/- ##
=======================================
Coverage 71.22% 71.22%
=======================================
Files 103 103
Lines 12002 12002
=======================================
Hits 8549 8549
Misses 3453 3453 |
Let me see if I get this... I'll just trust you on the number of oscillators. Regarding the frequency, the point is that the graphical interface specifies the available sampling rates as
but you and I both know that these numbers are not exact, merely rounded off to 3 significant digits. In fact, the true frequencies are
, i.e. all numbers that can be represented exactly. Okay, I get it. I agree. |
The only weakness is: how well do we know the original frequency? @qSaevar ? |
@WilliamHPNielsen the original frequency? Do you mean the base 1.8GHz or the internal ref frequency? In the manual it is stated that the short term stability of the internal clock is 0.00005 ppm with typical initial accuracy of +/- 0.5 ppm and max of +/- 1 ppm. But then there is the possibility of using an external reference clock... |
@WilliamHPNielsen I fixed the setter for sampling rate and I have tested this on hardware. Should I do anything else? Or what is the status of this PR. |
@qSaevar I meant the base frequency of 1.8 GHz. If that could potentially be 1.804 GHz, things would be bad. But you've answered that question now, thanks. We'll merge once CI is happy. |
@WilliamHPNielsen That's great, thanks |
Changes proposed in this pull request:
@WilliamHPNielsen