Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter for connection demodulator with selected oscillator #1551

Merged
merged 4 commits into from
May 7, 2019
Merged

Add parameter for connection demodulator with selected oscillator #1551

merged 4 commits into from
May 7, 2019

Conversation

qSaevar
Copy link
Contributor

@qSaevar qSaevar commented May 1, 2019

Changes proposed in this pull request:

  • Add parameter to UHFLI driver to select oscillator per demodulator

@WilliamHPNielsen

@codecov
Copy link

codecov bot commented May 1, 2019 •
edited

Codecov Report

Merging #1551 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1551   +/-   ##
=======================================
  Coverage   71.45%   71.45%           
=======================================
  Files         105      105           
  Lines       12106    12106           
=======================================
  Hits         8650     8650           
  Misses       3456     3456

WilliamHPNielsen
WilliamHPNielsen approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@WilliamHPNielsen WilliamHPNielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll admit that I have not tested the changes on a real unit, but let's just get it in.

@qSaevar
Copy link
Contributor Author

qSaevar commented May 7, 2019

@WilliamHPNielsen Great thanks. I have only tested this on a device with MF enabled.

@WilliamHPNielsen
Copy link
Contributor

@qSaevar, that's what I thought. And I have one without MF, so that could be good to test, but I'll risk it, just this once.

@WilliamHPNielsen WilliamHPNielsen merged commit 52b5b1d into microsoft:master May 7, 2019
giulioungaretti pushed a commit that referenced this pull request May 7, 2019
Generated gh-pages for commit 52b5b1d
b7ea5b0 
Merge: 1923c8d b0c9833
Author: William H.P. Nielsen <whpn@mailbox.org>

    Merge pull request #1551 from qutech-sd/uhfli_lock-in_select_oscillator
@qSaevar qSaevar deleted the uhfli_lock-in_select_oscillator branch May 7, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamHPNielsen WilliamHPNielsen WilliamHPNielsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qSaevar @WilliamHPNielsen