Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add parameter for Keysight E8267D IQ modulator #1554

Merged
merged 7 commits into from
May 6, 2019
Merged

add parameter for Keysight E8267D IQ modulator #1554

merged 7 commits into from
May 6, 2019

Conversation

eendebakpt
Copy link
Contributor

@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #1554 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1554   +/-   ##
=======================================
  Coverage   71.31%   71.31%           
=======================================
  Files         104      104           
  Lines       12045    12045           
=======================================
  Hits         8590     8590           
  Misses       3455     3455

@peendebak
Copy link
Contributor

@astafan8 I added create_on_off_val_mapping. The argument names I kept the same, so they keep matching the command names on the actual instrument.

@astafan8 astafan8 added the driver label May 5, 2019
@astafan8 astafan8 merged commit 1e71722 into microsoft:master May 6, 2019
giulioungaretti pushed a commit that referenced this pull request May 6, 2019
Generated gh-pages for commit 1e71722
18a8594 
Merge: 075f58c c681c80
Author: Mikhail Astafev <astafan8@gmail.com>

    Merge pull request #1554 from qutech-sd/feature/E8267D_parameters
@peendebak peendebak mentioned this pull request Aug 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peendebak peendebak peendebak left review comments

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
driver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eendebakpt @peendebak @astafan8