Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryocon / Allow setting termination character #1559

Merged
merged 2 commits into from
May 8, 2019
Merged

Conversation

astafan8
Copy link
Contributor

@astafan8 astafan8 commented May 8, 2019

  • Make termination a kwarg of init, and pass it to super's init call.
  • remove reset argument

Delft users discovered that the terminator is actually \r\n although \n also works. The hint to this was discovered when the queue of the visa responses got out of sync. But i've decided not to change the default terminator and just let the users set it, and if they confirm with usage that \r\n is the right one, then we'll change it.

Make it a kwarg of init, instead of it being hard-coded in super's init call.
@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #1559 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1559   +/-   ##
=======================================
  Coverage   71.54%   71.54%           
=======================================
  Files         105      105           
  Lines       12133    12133           
=======================================
  Hits         8681     8681           
  Misses       3452     3452

@astafan8 astafan8 merged commit 599616f into master May 8, 2019
@astafan8 astafan8 deleted the cryocon-driver-fix branch May 8, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants