Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warning when taking snapshot of ZIHDAWG8 #1561

Merged
merged 7 commits into from
May 14, 2019
Merged

Remove warning when taking snapshot of ZIHDAWG8 #1561

merged 7 commits into from
May 14, 2019

Conversation

qSaevar
Copy link
Contributor

@qSaevar qSaevar commented May 13, 2019

Changes proposed in this pull request:

  • update parameter in ZIHDAWG.snapshot_base should work as advertised.
  • feature_code should be ignored when getting an update snapshot.

@WilliamHPNielsen

@codecov
Copy link

codecov bot commented May 13, 2019 •
edited

Codecov Report

Merging #1561 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1561   +/-   ##
=======================================
  Coverage   71.54%   71.54%           
=======================================
  Files         105      105           
  Lines       12139    12139           
=======================================
  Hits         8685     8685           
  Misses       3454     3454

jenshnielsen
jenshnielsen reviewed May 13, 2019
View reviewed changes
Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible. Left a single inline question

qcodes/instrument_drivers/ZI/ZIHDAWG8.py Show resolved Hide resolved
jenshnielsen
jenshnielsen reviewed May 14, 2019
View reviewed changes
qcodes/instrument_drivers/ZI/ZIHDAWG8.py Outdated
return super(ZIHDAWG8, self).snapshot_base(update=True,
params_to_skip_update=None)
def snapshot_base(self, update: bool = True,
params_to_skip_update: Sequence[str] = 'features_code') -> Dict:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a sequence of strings it should be ('features_code',)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right

@WilliamHPNielsen WilliamHPNielsen changed the title Removed waring when taking snapshot of ZIHDAWG8 Remove warning when taking snapshot of ZIHDAWG8 May 14, 2019
@jenshnielsen
Copy link
Collaborator

Will merge once ci passes

@jenshnielsen jenshnielsen merged commit cc4ca84 into microsoft:master May 14, 2019
@qSaevar qSaevar deleted the hdawg8_snapshot_generates_a_warning branch May 14, 2019 13:26
giulioungaretti pushed a commit that referenced this pull request May 14, 2019
Generated gh-pages for commit cc4ca84
4408477 
Merge: 660a553 c8aec15
Author: Jens Hedegaard Nielsen <Jens.Nielsen@microsoft.com>

    Merge pull request #1561 from qutech-sd/hdawg8_snapshot_generates_a_warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenshnielsen jenshnielsen jenshnielsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qSaevar @jenshnielsen