Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB upgrade: version 5 - snapshot column ALWAYS present in runs table #1562

Merged
merged 12 commits into from
May 13, 2019
Merged

DB upgrade: version 5 - snapshot column ALWAYS present in runs table #1562

merged 12 commits into from
May 13, 2019

Conversation

astafan8
Copy link
Contributor

@astafan8 astafan8 commented May 13, 2019 •
edited

Make snapshot column (of type "TEXT") always present in runs table. This way it becomes part of the stable schema, not a "metadata" column anymore.

Relies on version 4 database generator from here QCoDeS/qcodes_generate_test_db#3.

Also couldn't resist fixing some of the style stuff.

ToDo:

  • remove checking out branch of qcodes_generate_test_db
  • update the hash in qcodes_generate_test_db to really the latest hash before merging this PR

@astafan8 astafan8 self-assigned this May 13, 2019
jenshnielsen
jenshnielsen reviewed May 13, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
jenshnielsen
jenshnielsen approved these changes May 13, 2019
View reviewed changes
Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me to go in as soon as it points to the master banch of the db repo

@codecov
Copy link

codecov bot commented May 13, 2019 •
edited

Codecov Report

Merging #1562 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1562      +/-   ##
==========================================
+ Coverage   71.54%   71.54%   +<.01%     
==========================================
  Files         105      105              
  Lines       12137    12139       +2     
==========================================
+ Hits         8683     8685       +2     
  Misses       3454     3454

@WilliamHPNielsen WilliamHPNielsen mentioned this pull request May 13, 2019
Closed
1 task
@astafan8 astafan8 merged commit 660a553 into microsoft:master May 13, 2019
@astafan8 astafan8 deleted the db-upgrade-fix-snapshot-column branch May 13, 2019 16:05
giulioungaretti pushed a commit that referenced this pull request May 13, 2019
Generated gh-pages for commit 660a553
fc9a5f4 
Merge: 57ad871 3a624d7
Author: Mikhail Astafev <astafan8@gmail.com>

    Merge pull request #1562 from astafan8/db-upgrade-fix-snapshot-column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenshnielsen jenshnielsen jenshnielsen approved these changes

Assignees

@astafan8 astafan8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@astafan8 @jenshnielsen