Version RunDescriber, and 5->6 DB upgrade, also reorg run descriptions module structure #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamHPNielsen
force-pushed
the
dev/reorg_runs_descriptions
branch
2 times, most recently
from
04571f1
to
accb981
Compare
WilliamHPNielsen
force-pushed
the
dev/reorg_runs_descriptions
branch
from
accb981
to
ea18d78
Compare
Codecov Report
@@ Coverage Diff @@
## master #1577 +/- ##
==========================================
+ Coverage 72.18% 72.33% +0.14%
==========================================
Files 112 116 +4
Lines 12293 12388 +95
==========================================
+ Hits 8874 8961 +87
- Misses 3419 3427 +8 |
Add an extra layer of (de)serialization functions for the RunDescriber objects
astafan8
force-pushed
the
dev/reorg_runs_descriptions
branch
from
5b14fe9
to
61d0bec
Compare
... and make update_run_description use _update_run_description internally. If _update_run_description becomes useful in too many place it can be promoted to be non-private and perhaps get a better name.
as introduced by one of the previous commits. writing the version field is probably not harmful, but inconsistent with the original behavior of the function, hence this commits removes this inconsistency.
To ensure that the fix does indeed what it's supposed to.
The logic of conversion between the wrongly written run_description to what it should be is a bit involved since we are using conversion functions from serializion.py module. So we factor out that code into its own function and document it heavily.
astafan8
force-pushed
the
dev/reorg_runs_descriptions
branch
from
03a35e5
to
cc8465b
Compare
See the updated docstring of the module for the info on the convention.
astafan8
force-pushed
the
dev/reorg_runs_descriptions
branch
from
18b0239
to
acfb5d5
Compare
|
This looks good! Let's get it in. |
giulioungaretti
pushed a commit
that referenced
this pull request
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for how the
RunDescriberobject could be versioned. Hopefully, this will allow us to decouple changes to the RunDescriber object from the SQLite schema version.Changes proposed in this pull request:
descriptionspackage where all theRunDescriber/InterDependencies/ParamSpec/etc goRunDescriberRunDescriberinversioningpackage'version'with the value of0qcodes.dataset.sqlite_base,qcodes.dataset.database,qcodes.dataset.param_spec)serializeto_to_dictanddeserializeto_from_dictfor RunDescriber (all versions), InterDependencies_, InterDependencies, ParamSpecBase (also make those methods private)qcodes.dataset.sqlite_base,qcodes.dataset.database,qcodes.dataset.param_specin notebooks and in codeThis PR is originally based on #1566.