Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / snapshot_base params_to_skip_update #1584

Merged
merged 11 commits into from
Jun 4, 2019

Conversation

WilliamHPNielsen
Copy link
Contributor

We found out that there's currently a bug in snapshot_base: if the snapshot encounters a parameter that should be skipped (as given by the params_to_skip_update argument), it will skip the update of all subsequent parameters.

Changes proposed in this pull request:

  • Add a test for this behaviour
  • Fix the skipping logic
  • Add Optional to the type annotations for params_to_skip_update

@QCoDeS/core

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #1584 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1584      +/-   ##
==========================================
+ Coverage   72.33%   72.34%   +0.01%     
==========================================
  Files         116      116              
  Lines       12389    12390       +1     
==========================================
+ Hits         8962     8964       +2     
+ Misses       3427     3426       -1

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok, but perhaps the test can be improved.

qcodes/tests/test_snapshot.py Show resolved Hide resolved
qcodes/tests/test_snapshot.py Outdated Show resolved Hide resolved
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time for this to get in :)

Thanks for improving the test!

@astafan8 astafan8 merged commit 5f6fd68 into microsoft:master Jun 4, 2019
@astafan8 astafan8 deleted the fix/snapshot_base_skips branch June 4, 2019 23:36
giulioungaretti pushed a commit that referenced this pull request Jun 5, 2019
Merge: d13cab3 71dddfa
Author: Mikhail Astafev <astafan8@gmail.com>

    Merge pull request #1584 from WilliamHPNielsen/fix/snapshot_base_skips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants